test: remove dead code#25009

Closed

BridgeAR wants to merge 2 commits intonodejs:masterfrom

BridgeAR:remove-dead-code

Member

BridgeAR commented Dec 13, 2018

This is not used by the test anymore.

I am uncertain why this is not found by eslint but I did not check.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines


          test: remove dead code

3b4799f

This is not used by the test anymore.

Collaborator

nodejs-github-bot commented Dec 13, 2018

@BridgeAR build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1921/pipeline

nodejs-github-bot added the test label


          test: run eslint on test file and fix errors

aa48e32

This removes two entries from the eslint ignore file. One file does
not exist anymore and the other one could easily be fixed.

BridgeAR commented

View reviewed changes

.eslintignore

    
            @@ -1,9 +1,7 @@
          
              node_modules

              lib/internal/v8.js

              lib/internal/v8_prof_polyfill.js

Member Author

BridgeAR Dec 13, 2018

I am not sure what this file does. Do we have to ignore the file here?

Member

Trott Dec 15, 2018

My vague recollection: I think the file was originally copied from either V8 source or a V8 change proposal that may have been rejected by V8. Since we were copying the file, we didn't apply our lint style to it since we would just copy changes from upstream at a later date, presumably. This is similar, I think, to how we handle punycode.js. It looks like we may now basically own v8_prof_polyfill.js, though. I'm not sure. @matthewloring may know,.

thefourtheye approved these changes

View reviewed changes

Member Author

BridgeAR commented Dec 13, 2018

CI https://ci.nodejs.org/job/node-test-pull-request/19479/

BridgeAR added the author ready label

Trott approved these changes

View reviewed changes

Member

Trott commented Dec 15, 2018 •

edited

Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/19561/ ✔️

Trott pushed a commit to Trott/io.js that referenced this pull request


          test: remove dead code

This is not used by the test anymore.

PR-URL: nodejs#25009
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

Trott pushed a commit to Trott/io.js that referenced this pull request


          test: run eslint on test file and fix errors

This removes two entries from the eslint ignore file. One file does
not exist anymore and the other one could easily be fixed.

PR-URL: nodejs#25009
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

Member

Trott commented Dec 15, 2018

Landed in e7c3a1b...1395256

Trott closed this

BethGriggs pushed a commit that referenced this pull request


          test: remove dead code

110fd39

This is not used by the test anymore.

PR-URL: #25009
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

BethGriggs pushed a commit that referenced this pull request


          test: run eslint on test file and fix errors

ddff644

This removes two entries from the eslint ignore file. One file does
not exist anymore and the other one could easily be fixed.

PR-URL: #25009
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

BethGriggs mentioned this pull request

V11.5.0 proposal #25102

Merged

beevelop mentioned this pull request

2018-12-18 Version 11.5.0 (Current) @BethGriggs beevelop/docker-android-nodejs#272

Closed

refack pushed a commit to refack/node that referenced this pull request


          test: remove dead code

b87c46a

This is not used by the test anymore.

PR-URL: nodejs#25009
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

refack pushed a commit to refack/node that referenced this pull request


          test: run eslint on test file and fix errors

91475fd

This removes two entries from the eslint ignore file. One file does
not exist anymore and the other one could easily be fixed.

PR-URL: nodejs#25009
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

BethGriggs pushed a commit that referenced this pull request


          test: remove dead code

This is not used by the test anymore.

PR-URL: #25009
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

BethGriggs pushed a commit that referenced this pull request


          test: run eslint on test file and fix errors

bcfc1d1

This removes two entries from the eslint ignore file. One file does
not exist anymore and the other one could easily be fixed.

PR-URL: #25009
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

BethGriggs added the land-on-v10.x label

BethGriggs mentioned this pull request

v10.15.3 proposal #26063

Merged

BethGriggs pushed a commit that referenced this pull request


          test: remove dead code

8b695c1

This is not used by the test anymore.

PR-URL: #25009
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

BethGriggs pushed a commit that referenced this pull request


          test: run eslint on test file and fix errors

f9446fe

This removes two entries from the eslint ignore file. One file does
not exist anymore and the other one could easily be fixed.

PR-URL: #25009
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

rvagg pushed a commit that referenced this pull request


          test: remove dead code

b1d7a2f

This is not used by the test anymore.

PR-URL: #25009
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

rvagg pushed a commit that referenced this pull request


          test: run eslint on test file and fix errors

cc7727e

This removes two entries from the eslint ignore file. One file does
not exist anymore and the other one could easily be fixed.

PR-URL: #25009
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

BridgeAR deleted the remove-dead-code branch

January 20, 2020 11:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready test